Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: Source/core/dom/DocumentParser.h

Issue 73293003: Moved setting of visual ordering from DocumentWriter to DecodedDataDocument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@parserthread_decoderownership
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/DocumentParser.h
diff --git a/Source/core/dom/DocumentParser.h b/Source/core/dom/DocumentParser.h
index 1b0e91f8a52579d5f2d2cb2d7c393b79334941eb..fa1d90a40c3fc2bf359f40bed0799789d4b054b2 100644
--- a/Source/core/dom/DocumentParser.h
+++ b/Source/core/dom/DocumentParser.h
@@ -49,11 +49,12 @@ public:
virtual void insert(const SegmentedString&) = 0;
// The below functions are used by DocumentWriter (the loader).
- virtual size_t appendBytes(const char* bytes, size_t length) = 0;
- virtual size_t flush() = 0;
+ virtual void appendBytes(const char* bytes, size_t length) = 0;
+ virtual void flush() = 0;
virtual bool needsDecoder() const { return false; }
virtual void setDecoder(PassRefPtr<TextResourceDecoder>);
virtual PassRefPtr<TextResourceDecoder> decoder();
+ virtual void setHasAppendedData() { }
eseidel 2013/11/18 23:46:08 Curious why this needs to be defined here?
oystein (OOO til 10th of July) 2013/11/18 23:51:56 Even more strange hackiness :). DocumentWriter::ap
// pinToMainThread also makes append() not yield before completion of that chunk.
virtual void pinToMainThread() { }

Powered by Google App Engine
This is Rietveld 408576698