Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: Source/core/dom/DecodedDataDocumentParser.h

Issue 73293003: Moved setting of visual ordering from DocumentWriter to DecodedDataDocument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@parserthread_decoderownership
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/DecodedDataDocumentParser.cpp » ('j') | Source/core/dom/DocumentParser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DecodedDataDocumentParser.h
diff --git a/Source/core/dom/DecodedDataDocumentParser.h b/Source/core/dom/DecodedDataDocumentParser.h
index c237175c2c38277e11f5fe7f5b8b291de1e514f8..58519f45ecd02eba7dbf4326d506b7eb6afa0eef 100644
--- a/Source/core/dom/DecodedDataDocumentParser.h
+++ b/Source/core/dom/DecodedDataDocumentParser.h
@@ -39,11 +39,12 @@ public:
virtual bool wellFormed() const { return true; }
// The below functions are used by DocumentWriter (the loader).
- virtual size_t appendBytes(const char* bytes, size_t length) OVERRIDE;
- virtual size_t flush() OVERRIDE;
+ virtual void appendBytes(const char* bytes, size_t length) OVERRIDE;
+ virtual void flush() OVERRIDE;
virtual bool needsDecoder() const OVERRIDE { return !m_decoder; }
virtual void setDecoder(PassRefPtr<TextResourceDecoder>) OVERRIDE;
virtual PassRefPtr<TextResourceDecoder> decoder() OVERRIDE;
+ virtual void setHasAppendedData() OVERRIDE;
eseidel 2013/11/18 23:46:08 Why does this need to be virtual?
protected:
explicit DecodedDataDocumentParser(Document*);
@@ -53,8 +54,9 @@ private:
// append is used by DocumentWriter::replaceDocument.
virtual void append(PassRefPtr<StringImpl>) = 0;
- void updateDocumentEncoding();
+ void updateDocument(String& decodedData);
+ bool m_hasAppendedData;
RefPtr<TextResourceDecoder> m_decoder;
};
« no previous file with comments | « no previous file | Source/core/dom/DecodedDataDocumentParser.cpp » ('j') | Source/core/dom/DocumentParser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698