Patch RecordWriteStub after adding it to the stub cache not during generation.

Patch RecordWriteStub after adding it to the stub cache not during generation.

This guarantees that stub's mode will match the state of incremental marker.

R=lrn@chromium.org
BUG=v8:1545
Committed: http://code.google.com/p/v8/source/detail?r=8618

[Lasse Reichstein, 2011-07-12 06:44:16]

LGTM

http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode125
src/code-stubs.cc:125: heap->incremental_marking()->ActivateGeneratedStub(code);
Seems like the wrong direction of dependency, to make the CodeStub superclass
know about a specific kind of subclass.
How about calling a virtual callback function on the stub that only do something
if it's needed.

http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode165
src/code-stubs.cc:165: } else if (MajorKey() == RecordWrite) {
Again, create a virtual function, e.g., MustBeCached(), that returns true on the
RecordWrite stub.

http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode172
src/code-stubs.cc:172: heap->incremental_marking()->ActivateGeneratedStub(code);
And again.

http://codereview.chromium.org/7329049/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

http://codereview.chromium.org/7329049/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:310: RecordWriteStub::STORE_BUFFER_ONLY);
Indent to '(' or four chars from start of statement, not four chars from '('.

[Vyacheslav Egorov (Chromium), 2011-07-12 11:17:11]

Thanks. Landing.

http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode125
src/code-stubs.cc:125: heap->incremental_marking()->ActivateGeneratedStub(code);
On 2011/07/12 06:44:16, Lasse Reichstein wrote:
> Seems like the wrong direction of dependency, to make the CodeStub superclass
> know about a specific kind of subclass.
> How about calling a virtual callback function on the stub that only do
something
> if it's needed.

I did not want to introduce two virtual function for such a small thingy. (btw
MajorKey returns enum which contains all "subclasses" so CodeStub already knows
everything about it's subclasses).

Nevertheless I agree that virtual functions are slightly cleaner way of doing
this. Done.

http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode165
src/code-stubs.cc:165: } else if (MajorKey() == RecordWrite) {
On 2011/07/12 06:44:16, Lasse Reichstein wrote:
> Again, create a virtual function, e.g., MustBeCached(), that returns true on
the
> RecordWrite stub.

Done.

http://codereview.chromium.org/7329049/diff/1/src/code-stubs.cc#newcode172
src/code-stubs.cc:172: heap->incremental_marking()->ActivateGeneratedStub(code);
On 2011/07/12 06:44:16, Lasse Reichstein wrote:
> And again.

Done.

http://codereview.chromium.org/7329049/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

http://codereview.chromium.org/7329049/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:310: RecordWriteStub::STORE_BUFFER_ONLY);
On 2011/07/12 06:44:16, Lasse Reichstein wrote:
> Indent to '(' or four chars from start of statement, not four chars from '('.

Done.