Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 732683002: Timeline: bring back FirstPaint marker and remove brown ticks near frame markers (Closed)

Created:
6 years, 1 month ago by caseq
Modified:
6 years, 1 month ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Timeline: bring back FirstPaint marker and remove brown ticks near frame markers - implement synthetic FirstPaint markers on front-end (they used to be generated on the back-end with old Timeline instrumentation which is an ex-parrot) - remove brown marks near the frame markers (regressed at r177959) BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M LayoutTests/inspector/tracing/timeline-load-event.html View 4 chunks +10 lines, -2 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-load-event-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 5 chunks +18 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
6 years, 1 month ago (2014-11-14 18:10:59 UTC) #2
pfeldman
lgtm.
6 years, 1 month ago (2014-11-14 19:43:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732683002/1
6 years, 1 month ago (2014-11-14 19:56:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 185392
6 years, 1 month ago (2014-11-14 21:20:40 UTC) #6
caseq
6 years ago (2014-11-26 16:50:49 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/761493004/ by caseq@chromium.org.

The reason for reverting is: This is wrong as it processes trace events from
different trace threads and relied on their relative order. Let's do it right
from scratch so that it's easier to merge..

Powered by Google App Engine
This is Rietveld 408576698