Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 732683002: Timeline: bring back FirstPaint marker and remove brown ticks near frame markers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js
index 0a768dfee48b297b2e9f2f7b585eae4f5208c946..dc9c8b2105a37b6fddb61b33e38c80b66a8374ed 100644
--- a/Source/devtools/front_end/timeline/TimelineModel.js
+++ b/Source/devtools/front_end/timeline/TimelineModel.js
@@ -755,6 +755,8 @@ WebInspector.TimelineModel.prototype = {
this._lastRecalculateStylesEvent = null;
this._currentScriptEvent = null;
this._eventStack = [];
+ this._layerTreeActivatedAfterLoad = false;
+ this._expectFirstPaint = false;
},
/**
@@ -765,6 +767,7 @@ WebInspector.TimelineModel.prototype = {
*/
_processThreadEvents: function(startTime, endTime, mainThread, thread)
{
+ var recordTypes = WebInspector.TimelineModel.RecordType;
var events = thread.events();
var length = events.length;
var i = events.lowerBound(startTime, function (time, event) { return time - event.startTime });
@@ -787,6 +790,10 @@ WebInspector.TimelineModel.prototype = {
if (endTime && event.startTime >= endTime)
break;
this._processEvent(event);
+ if (this._expectFirstPaint && event.name === recordTypes.DrawFrame && this._layerTreeActivatedAfterLoad) {
+ threadEvents.push(new WebInspector.TracingModel.Event(event.category, recordTypes.MarkFirstPaint, WebInspector.TracingModel.Phase.Instant, event.startTime, event.thread));
+ this._expectFirstPaint = false;
+ }
threadEvents.push(event);
this._inspectedTargetEvents.push(event);
}
@@ -813,7 +820,6 @@ WebInspector.TimelineModel.prototype = {
_processEvent: function(event)
{
var recordTypes = WebInspector.TimelineModel.RecordType;
-
var eventStack = this._eventStack;
while (eventStack.length && eventStack.peekLast().endTime < event.startTime)
eventStack.pop();
@@ -983,6 +989,17 @@ WebInspector.TimelineModel.prototype = {
event.backendNodeId = paintImageEvent.backendNodeId;
event.imageURL = paintImageEvent.imageURL;
break;
+
+ case recordTypes.MarkDOMContent:
+ if (!event.args["data"]["isMainFrame"])
+ break;
+ this._expectFirstPaint = true;
+ this._layerTreeActivatedAfterLoad = false;
+ break;
+
+ case recordTypes.ActivateLayerTree:
+ this._layerTreeActivatedAfterLoad = true;
+ break;
}
},
« no previous file with comments | « LayoutTests/inspector/tracing/timeline-load-event-expected.txt ('k') | Source/devtools/front_end/timeline/timelinePanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698