The text color for BookmarkButton sometimes doesn't get updated.

chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h
index cce330289d745e497af93e0aed9719ac7ea74a2c..86f9df23b51d0a98192701147654ff42fbf46ca8 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h
@@ -28,6 +28,8 @@ class BookmarkNode;
 
   // Arrow for folders
   scoped_nsobject<NSImage> arrowImage_;
+
+  scoped_nsobject<NSColor> textColor_;

[John Grabowski, 2011/07/11 21:48:12]

Looks like the convention in this class is to have a comment for all data
members.  You should add one for your new member.

 }
 
 @property(nonatomic, readwrite, assign) const BookmarkNode* bookmarkNode;
@@ -59,6 +61,7 @@ class BookmarkNode;
 
 // Set the color of text in this cell.
 - (void)setTextColor:(NSColor*)color;
+- (void)applyTextColor;

[John Grabowski, 2011/07/11 21:48:12]

Reading the header it would be unclear when or why someone should call
applyTextColor.  Shouldn't that be automatic?

Seems like you'd want this to be a "private" protocol.

 
 - (BOOL)isFolderButtonCell;