The text color for BookmarkButton sometimes doesn't get updated.

chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BUTTON_CELL_H_
 #define CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BUTTON_CELL_H_
 #pragma once
 
 #import "base/mac/cocoa_protocols.h"
 #import "chrome/browser/ui/cocoa/gradient_button_cell.h"
@@ skipping 10 matching lines @@
 
   // Starting index of bookmarkFolder children that we care to use.
   int startingChildIndex_;
 
   // Should we draw the folder arrow as needed?  Not used for the bar
   // itself but used on the folder windows.
   BOOL drawFolderArrow_;
 
   // Arrow for folders
   scoped_nsobject<NSImage> arrowImage_;
+
+  scoped_nsobject<NSColor> textColor_;

[John Grabowski, 2011/07/11 21:48:12]

Looks like the convention in this class is to have a comment for all data
members.  You should add one for your new member.

 }
 
 @property(nonatomic, readwrite, assign) const BookmarkNode* bookmarkNode;
 @property(nonatomic, readwrite, assign) int startingChildIndex;
 @property(nonatomic, readwrite, assign) BOOL drawFolderArrow;
 
 // Create a button cell which draws with a theme.
 + (id)buttonCellForNode:(const BookmarkNode*)node
             contextMenu:(NSMenu*)contextMenu
                cellText:(NSString*)cellText
@@ skipping 11 matching lines @@
 
 // |-setBookmarkCellText:image:| is used to set the text and image of
 // a BookmarkButtonCell, and align the image to the left (NSImageLeft)
 // if there is text in the title, and centered (NSImageCenter) if
 // there is not.  If |title| is nil, do not reset the title.
 - (void)setBookmarkCellText:(NSString*)title
                       image:(NSImage*)image;
 
 // Set the color of text in this cell.
 - (void)setTextColor:(NSColor*)color;
+- (void)applyTextColor;

[John Grabowski, 2011/07/11 21:48:12]

Reading the header it would be unclear when or why someone should call
applyTextColor.  Shouldn't that be automatic?

Seems like you'd want this to be a "private" protocol.

 
 - (BOOL)isFolderButtonCell;
 
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BUTTON_CELL_H_