Issue 732483002: bindings: make toImplArguments() less strict

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 732483002: bindings: make toImplArguments() less strict (Closed)

Created:
6 years, 1 month ago by Jens Widell

Modified:
6 years, 1 month ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

bindings: make toImplArguments() less strict Allow it to be called with startIndex that is greater than info.Length(). This will happen from the generated code for a method such as void f(long x, optional long y = 0, long... rest); when called with a single argument. Also a minor improvement: reserve a tighter initial capacity for the result vector. Capacity used to be reserved for storing all arguments, disregarding the startIndex value. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185366