Issue 7324049: Do nothing in IncrementalMarking::Step when we are not marking or sweeping.

Issue 7324049: Do nothing in IncrementalMarking::Step when we are not marking or sweeping. (Closed)

Created:
9 years, 5 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 5 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Do nothing in IncrementalMarking::Step when we are not marking or sweeping. R=lrn@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8617

Patch Set 1 #

Total comments: 4

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/incremental-marking.cc	View		1 chunk	+1 line, -0 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

http://codereview.chromium.org/7324049/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): http://codereview.chromium.org/7324049/diff/1/src/incremental-marking.cc#newcode541 src/incremental-marking.cc:541: if (!FLAG_incremental_marking_steps) return; Are FLAG_incremental_marking and FLAG_incremental_marking_steps forced to ...

9 years, 5 months ago (2011-07-12 08:18:32 UTC) #2

Vyacheslav Egorov (Chromium)

9 years, 5 months ago (2011-07-12 09:27:54 UTC) #4

Landing.

http://codereview.chromium.org/7324049/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

http://codereview.chromium.org/7324049/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:541: if (!FLAG_incremental_marking_steps) return;
On 2011/07/12 08:18:32, Lasse Reichstein wrote:
> Are FLAG_incremental_marking and FLAG_incremental_marking_steps forced to be
> dependent in any way? Should they be (i.e., it seems it should be sufficient
to
> check FLAG_incremental_marking_steps)?

They are independent.

http://codereview.chromium.org/7324049/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:542: if (state_ != SWEEPING && state_ != MARKING)
return;
On 2011/07/12 08:18:32, Lasse Reichstein wrote:
> How about combining all these conditions with || and just having one return?

Done.

Expand Messages | Collapse Messages