Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 732403002: MIPS64: Add turbofan support for mips64. (Closed)

Created:
6 years, 1 month ago by dusmil.imgtec
Modified:
6 years, 1 month ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove redundant check. #

Patch Set 3 : Disable rounding operations. #

Total comments: 2

Patch Set 4 : Addressed comments and code cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1098 lines, -397 lines) Patch
M src/compiler/instruction-codes.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/compiler/mips64/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/compiler/mips64/code-generator-mips64.cc View 1 2 28 chunks +387 lines, -110 lines 0 comments Download
A src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +106 lines, -0 lines 0 comments Download
A + src/compiler/mips64/instruction-selector-mips64.cc View 1 2 3 25 chunks +398 lines, -130 lines 0 comments Download
A + src/compiler/mips64/linkage-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/call-tester.h View 1 chunk +36 lines, -0 lines 0 comments Download
A + test/unittests/compiler/mips64/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 36 chunks +158 lines, -156 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dusmil.imgtec
6 years, 1 month ago (2014-11-18 14:31:19 UTC) #2
paul.l...
LGTM, with minor issues: see Lwu comment, and you should add an OWNERS file to ...
6 years, 1 month ago (2014-11-18 18:42:07 UTC) #3
dusmil.imgtec
https://codereview.chromium.org/732403002/diff/40001/src/compiler/mips64/instruction-selector-mips64.cc File src/compiler/mips64/instruction-selector-mips64.cc (right): https://codereview.chromium.org/732403002/diff/40001/src/compiler/mips64/instruction-selector-mips64.cc#newcode185 src/compiler/mips64/instruction-selector-mips64.cc:185: opcode = kMips64Lw; There is no need for that ...
6 years, 1 month ago (2014-11-19 12:45:55 UTC) #4
danno
lgtm
6 years, 1 month ago (2014-11-19 12:48:09 UTC) #5
dusmil.imgtec
6 years, 1 month ago (2014-11-19 15:44:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
ae9130ebbb3405ceb12e04ba5bad775624d51f3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698