Issue 7322012: Fix compilation on ARM and x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7322012: Fix compilation on ARM and x64. (Closed)

Created:
9 years, 5 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 5 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Fix compilation on ARM and x64. Enable incremental slots collection on x64. Fix test-api/ScriptUsingStringResource test. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=8575

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+136 lines, -60 lines)			Patch
M	src/arm/assembler-arm-inl.h	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	src/arm/code-stubs-arm.h	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	src/incremental-marking.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	2 chunks	+51 lines, -16 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	5 chunks	+52 lines, -27 lines	2 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 5 months ago (2011-07-08 09:06:49 UTC) #2

lgtm

http://codereview.chromium.org/7322012/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/7322012/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:5167: // branch when we start and stop incremental
heap marking.
This comment does not mention compaction.  I would suggest 'generated with a
label' rather than 'generated as a label'

http://codereview.chromium.org/7322012/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:5185: // it was added to a stub cache.
This looks nasty.  Please file a bug and put the bug number in here.  One way
may be to patch again just after it is added to the stub.

Expand Messages | Collapse Messages