expect_tests/type_definitions.py - Issue 731723002: Don't return failure if no tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: expect_tests/type_definitions.py

Issue 731723002: Don't return failure if no tests. (Closed) Base URL: https://chromium.googlesource.com/infra/testing/expect_tests@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: expect_tests/type_definitions.py

diff --git a/expect_tests/type_definitions.py b/expect_tests/type_definitions.py

index bc4bdd5dbb53bf12c8671a5c1b0eecc6dfba4349..b6b9d3ea8f88c39882cda42087cb4eafa18f223d 100644

--- a/expect_tests/type_definitions.py

+++ b/expect_tests/type_definitions.py

@@ -480,7 +480,8 @@ class Handler(object):

handler = cls.ResultStageHandler(opts)

try:

for obj in objects:

- error |= isinstance(handler(obj), Failure)

+ error |= (isinstance(handler(obj), Failure) and not

+ isinstance(obj, NoMatchingTestsError))

ghost stip (do not use) 2014/11/15 01:32:27 note that this is obj, and not handler(obj)

iannucci 2014/11/15 01:34:19 shouldn't this check come before we run handler on

ghost stip (do not use) 2014/11/15 01:38:12 Acknowledged.

except ResultStageAbort:

aborted = True

handler.finalize(aborted)

« no previous file with comments | « no previous file | no next file » | no next file with comments »