Don't return failure if no tests.

expect_tests/type_definitions.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from contextlib import contextmanager
 import copy
 import inspect
 import os
 import re
 
@@ skipping 462 matching lines @@
     flexible interface for dealing with |objects|.
 
     @param opts: Parsed CLI options
     @param objects: Iteraterable of objects from GenStage and RunStage.
     """
     error = False
     aborted = False
     handler = cls.ResultStageHandler(opts)
     try:
       for obj in objects:
-        error |= isinstance(handler(obj), Failure)
+        error |= (isinstance(handler(obj), Failure) and not
+                  isinstance(obj, NoMatchingTestsError))

[ghost stip (do not use), 2014/11/15 01:32:27]

note that this is obj, and not handler(obj)

[iannucci, 2014/11/15 01:34:19]

shouldn't this check come before we run handler on obj?

[ghost stip (do not use), 2014/11/15 01:38:12]

Acknowledged.

     except ResultStageAbort:
       aborted = True
     handler.finalize(aborted)
     return error
 
   class ResultStageHandler(object):
     """SAX-like event handler dispatches to self.handle_{type(obj).__name__}
 
     So if |obj| is a Test, this would call self.handle_Test(obj).
 
@@ skipping 24 matching lines @@
         print 'UNHANDLED:', obj
       return Failure()
 
     def finalize(self, aborted):
       """Called after __call__() has been called for all results.
 
       @param aborted: True if the user aborted the run.
       @type aborted: bool
       """
       pass