Don't return failure if no tests.

Don't return failure if no tests.

R=iannucci@chromium.org

Committed: https://chromium.googlesource.com/infra/testing/expect_tests/+/cd566a06dda3b2cd8823fad41ec9b927befdaeac

[ghost stip (do not use), 2014-11-15 01:31:55]

stip@chromium.org changed reviewers:
+ iannucci@chromium.org, pgervais@chromium.org

[ghost stip (do not use), 2014-11-15 01:32:27]

ptal, this fixes the bug where test.py returns 1 when given no arguments

https://codereview.chromium.org/731723002/diff/1/expect_tests/type_definition...
File expect_tests/type_definitions.py (right):

https://codereview.chromium.org/731723002/diff/1/expect_tests/type_definition...
expect_tests/type_definitions.py:484: isinstance(obj, NoMatchingTestsError))
note that this is obj, and not handler(obj)

[iannucci, 2014-11-15 01:34:19]

https://codereview.chromium.org/731723002/diff/1/expect_tests/type_definition...
File expect_tests/type_definitions.py (right):

https://codereview.chromium.org/731723002/diff/1/expect_tests/type_definition...
expect_tests/type_definitions.py:484: isinstance(obj, NoMatchingTestsError))
On 2014/11/15 01:32:27, stip wrote:
> note that this is obj, and not handler(obj)

shouldn't this check come before we run handler on obj?

[iannucci, 2014-11-15 01:35:58]

Actually I'd phrase it as

for obj in objects:
  if not isinstance(obj, NoMatchingTestsError):
    error |= isinstance(handler(obj), Failure)

[ghost stip (do not use), 2014-11-15 01:38:12]

guess what I just wrote :)

https://codereview.chromium.org/731723002/diff/1/expect_tests/type_definition...
File expect_tests/type_definitions.py (right):

https://codereview.chromium.org/731723002/diff/1/expect_tests/type_definition...
expect_tests/type_definitions.py:484: isinstance(obj, NoMatchingTestsError))
On 2014/11/15 01:34:19, iannucci wrote:
> On 2014/11/15 01:32:27, stip wrote:
> > note that this is obj, and not handler(obj)
> 
> shouldn't this check come before we run handler on obj?

Acknowledged.

[iannucci, 2014-11-15 01:41:54]

Totes lgtm

[ghost stip (do not use), 2014-11-15 01:42:55]

The CQ bit was checked by stip@chromium.org

[ghost stip (do not use), 2014-11-15 01:43:37]

Committed patchset #2 (id:20001) manually as
cd566a06dda3b2cd8823fad41ec9b927befdaeac (presubmit successful).