Remove Yoshi charger recall pop up warning UI code.

Remove Yoshi charger recall pop up warning UI code.

BUG=427057
TBR=gab,isherman

Committed: https://crrev.com/d2350e9c131ba4716e03e5ba755a29bf3cb068d9
Cr-Commit-Position: refs/heads/master@{#305048}

[jennyz, 2014-11-14 22:06:06]

jennyz@chromium.org changed reviewers:
+ derat@chromium.org, xiyuan@chromium.org

[xiyuan, 2014-11-14 22:09:10]

lgtm

[Daniel Erat, 2014-11-14 22:48:26]

https://codereview.chromium.org/731663002/diff/1/ash/system/chromeos/power/tr...
File ash/system/chromeos/power/tray_power.cc (left):

https://codereview.chromium.org/731663002/diff/1/ash/system/chromeos/power/tr...
ash/system/chromeos/power/tray_power.cc:292:
status.IsOriginalSpringChargerConnected()) {
i think we still want to include this here, at least until powerd is updated to
report the original spring charger as a regular mains charger. (do you want me
to check in a change to do that first?)

https://codereview.chromium.org/731663002/diff/1/ash/system/chromeos/power/tr...
ash/system/chromeos/power/tray_power.cc:374: void TrayPower::RecordChargerType()
{
it might be worthwhile to keep this metric around, but if you want to get rid of
it you should also mark it as deprecated in
tools/metrics/histograms/histograms.xml

[jennyz, 2014-11-15 00:04:04]

https://codereview.chromium.org/731663002/diff/1/ash/system/chromeos/power/tr...
File ash/system/chromeos/power/tray_power.cc (left):

https://codereview.chromium.org/731663002/diff/1/ash/system/chromeos/power/tr...
ash/system/chromeos/power/tray_power.cc:292:
status.IsOriginalSpringChargerConnected()) {
On 2014/11/14 22:48:26, Daniel Erat wrote:
> i think we still want to include this here, at least until powerd is updated
to
> report the original spring charger as a regular mains charger. (do you want me
> to check in a change to do that first?)

Yes, please check in the change for updating powerd before this cl if it does
not take too much trouble.

https://codereview.chromium.org/731663002/diff/1/ash/system/chromeos/power/tr...
ash/system/chromeos/power/tray_power.cc:374: void TrayPower::RecordChargerType()
{
On 2014/11/14 22:48:26, Daniel Erat wrote:
> it might be worthwhile to keep this metric around, but if you want to get rid
of
> it you should also mark it as deprecated in
> tools/metrics/histograms/histograms.xml

I deprecated it in the histograms.xml.

[Daniel Erat, 2014-11-17 16:34:21]

lgtm; powerd change is at https://chromium-review.googlesource.com/#/c/229979/
but not yet in

[jennyz, 2014-11-20 01:17:13]

The CQ bit was checked by jennyz@chromium.org

[commit-bot: I haz the power, 2014-11-20 01:18:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/731663002/20001

[commit-bot: I haz the power, 2014-11-20 01:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 01:25:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jennyz, 2014-11-20 17:46:34]

The CQ bit was checked by jennyz@chromium.org

[commit-bot: I haz the power, 2014-11-20 17:48:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/731663002/20001

[commit-bot: I haz the power, 2014-11-20 18:46:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-20 18:48:28]

Patchset 2 (id:??) landed as
https://crrev.com/d2350e9c131ba4716e03e5ba755a29bf3cb068d9
Cr-Commit-Position: refs/heads/master@{#305048}