Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: ash/system/chromeos/power/tray_power.cc

Issue 731663002: Remove Yoshi charger recall pop up warning UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Deprecat the related UMA metrics in histograms.xml. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/chromeos/power/tray_power.h ('k') | ash/system/chromeos/power/tray_power_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/chromeos/power/tray_power.cc
diff --git a/ash/system/chromeos/power/tray_power.cc b/ash/system/chromeos/power/tray_power.cc
index d5d410c8d660a49c62c6442ae585d49604b64290..3692cc2e3ef22cdb08f04cf9af20df0e0b9d782e 100644
--- a/ash/system/chromeos/power/tray_power.cc
+++ b/ash/system/chromeos/power/tray_power.cc
@@ -39,19 +39,11 @@ using message_center::Notification;
namespace ash {
namespace tray {
-namespace {
-
-const int kMaxSpringChargerAccessibilityNotifyCount = 3;
-const int kSpringChargerAccessibilityTimerFirstTimeNotifyInSeconds = 30;
-const int kSpringChargerAccessibilityTimerRepeatInMinutes = 5;
-
-}
// This view is used only for the tray.
class PowerTrayView : public views::ImageView {
public:
- PowerTrayView()
- : spring_charger_spoken_notification_count_(0) {
+ PowerTrayView() {
UpdateImage();
}
@@ -74,58 +66,13 @@ class PowerTrayView : public views::ImageView {
}
}
- void SetupNotifyBadCharger() {
- // Poll with a shorter duration timer to notify the charger issue
- // for the first time after the charger dialog is displayed.
- spring_charger_accessibility_timer_.Start(
- FROM_HERE, base::TimeDelta::FromSeconds(
- kSpringChargerAccessibilityTimerFirstTimeNotifyInSeconds),
- this, &PowerTrayView::NotifyChargerIssue);
- }
-
private:
void UpdateImage() {
SetImage(PowerStatus::Get()->GetBatteryImage(PowerStatus::ICON_LIGHT));
}
- void NotifyChargerIssue() {
- if (!Shell::GetInstance()->accessibility_delegate()->
- IsSpokenFeedbackEnabled())
- return;
-
- if (!Shell::GetInstance()->system_tray_delegate()->
- IsSpringChargerReplacementDialogVisible()) {
- spring_charger_accessibility_timer_.Stop();
- return;
- }
-
- accessible_name_ = ui::ResourceBundle::GetSharedInstance().
- GetLocalizedString(IDS_CHARGER_REPLACEMENT_ACCESSIBILITY_NOTIFICATION);
- NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true);
- ++spring_charger_spoken_notification_count_;
-
- if (spring_charger_spoken_notification_count_ == 1) {
- // After notify the charger issue for the first time, repeat the
- // notification with a longer duration timer.
- spring_charger_accessibility_timer_.Stop();
- spring_charger_accessibility_timer_.Start(
- FROM_HERE, base::TimeDelta::FromMinutes(
- kSpringChargerAccessibilityTimerRepeatInMinutes),
- this, &PowerTrayView::NotifyChargerIssue);
- } else if (spring_charger_spoken_notification_count_ >=
- kMaxSpringChargerAccessibilityNotifyCount) {
- spring_charger_accessibility_timer_.Stop();
- }
- }
-
base::string16 accessible_name_;
- // Tracks how many times the original spring charger accessibility
- // notification has been spoken.
- int spring_charger_spoken_notification_count_;
-
- base::RepeatingTimer<PowerTrayView> spring_charger_accessibility_timer_;
-
DISALLOW_COPY_AND_ASSIGN(PowerTrayView);
};
@@ -220,15 +167,6 @@ void TrayPower::UpdateAfterShelfAlignmentChange(ShelfAlignment alignment) {
}
void TrayPower::OnPowerStatusChanged() {
- RecordChargerType();
-
- if (PowerStatus::Get()->IsOriginalSpringChargerConnected()) {
- if (ash::Shell::GetInstance()->system_tray_delegate()->
- ShowSpringChargerReplacementDialog()) {
- power_tray_->SetupNotifyBadCharger();
- }
- }
-
bool battery_alert = UpdateNotificationState();
if (power_tray_)
power_tray_->UpdateStatus(battery_alert);
@@ -288,8 +226,7 @@ bool TrayPower::UpdateNotificationState() {
const PowerStatus& status = *PowerStatus::Get();
if (!status.IsBatteryPresent() ||
status.IsBatteryTimeBeingCalculated() ||
- status.IsMainsChargerConnected() ||
- status.IsOriginalSpringChargerConnected()) {
+ status.IsMainsChargerConnected()) {
notification_state_ = NOTIFICATION_NONE;
return false;
}
@@ -371,28 +308,4 @@ bool TrayPower::UpdateNotificationStateForRemainingPercentage() {
return false;
}
-void TrayPower::RecordChargerType() {
- if (!PowerStatus::Get()->IsLinePowerConnected() ||
- line_power_was_connected_)
- return;
-
- ChargerType current_charger = UNKNOWN_CHARGER;
- if (PowerStatus::Get()->IsMainsChargerConnected()) {
- current_charger = MAINS_CHARGER;
- } else if (PowerStatus::Get()->IsUsbChargerConnected()) {
- current_charger = USB_CHARGER;
- } else if (PowerStatus::Get()->IsOriginalSpringChargerConnected()) {
- current_charger =
- ash::Shell::GetInstance()->system_tray_delegate()->
- HasUserConfirmedSafeSpringCharger() ?
- SAFE_SPRING_CHARGER : UNCONFIRMED_SPRING_CHARGER;
- }
-
- if (current_charger != UNKNOWN_CHARGER) {
- UMA_HISTOGRAM_ENUMERATION("Power.ChargerType",
- current_charger,
- CHARGER_TYPE_COUNT);
- }
-}
-
} // namespace ash
« no previous file with comments | « ash/system/chromeos/power/tray_power.h ('k') | ash/system/chromeos/power/tray_power_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698