Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 731593003: Disable channel id (Closed)

Created:
6 years, 1 month ago by sgurun-gerrit only
Modified:
6 years, 1 month ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable channel id Android webview does not use channel id since there is no API to share channel ids and this would break some apps that use different network stacks. This change is to explicitly disable it. BUG=433427 internal bug b/18297802 Committed: https://crrev.com/a05fb84e005d38bfd4c44e15bd72ec6636d5058c Cr-Commit-Position: refs/heads/master@{#304316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sgurun-gerrit only
6 years, 1 month ago (2014-11-14 19:12:42 UTC) #2
sgurun-gerrit only
On 2014/11/14 19:12:42, sgurun wrote: ptal, thanks!
6 years, 1 month ago (2014-11-14 19:12:51 UTC) #3
mmenke
On 2014/11/14 19:12:51, sgurun wrote: > On 2014/11/14 19:12:42, sgurun wrote: > > ptal, thanks! ...
6 years, 1 month ago (2014-11-14 22:48:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731593003/1
6 years, 1 month ago (2014-11-14 22:54:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-15 00:39:35 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 00:47:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a05fb84e005d38bfd4c44e15bd72ec6636d5058c
Cr-Commit-Position: refs/heads/master@{#304316}

Powered by Google App Engine
This is Rietveld 408576698