Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 731443002: [LayoutTest] Fix xmlhttprequest-responseXML-nopartial flakiness. (Closed)

Created:
6 years, 1 month ago by yhirano
Modified:
6 years, 1 month ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[LayoutTest] Fix xmlhttprequest-responseXML-nopartial flakiness. xmlhttprequest-responseXML-nopartial used resources/small-chunks.cgi that takes 5 seconds to complete and it led to flaky timeout. Let's use a usual response. BUG=432784 R=kouhei Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185364

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M LayoutTests/http/tests/xmlhttprequest/resources/small-chunks.cgi View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
yhirano
6 years, 1 month ago (2014-11-14 06:59:57 UTC) #1
kouhei (in TOK)
https://codereview.chromium.org/731443002/diff/20001/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html File LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html (right): https://codereview.chromium.org/731443002/diff/20001/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html#newcode20 LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html:20: xhr.open("GET", "resources/test.html", true); The reason I used small-chunks here ...
6 years, 1 month ago (2014-11-14 07:40:53 UTC) #2
yhirano
https://codereview.chromium.org/731443002/diff/20001/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html File LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html (right): https://codereview.chromium.org/731443002/diff/20001/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html#newcode20 LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html:20: xhr.open("GET", "resources/test.html", true); On 2014/11/14 07:40:52, kouhei wrote: > ...
6 years, 1 month ago (2014-11-14 08:56:57 UTC) #3
kouhei (in TOK)
lgtm
6 years, 1 month ago (2014-11-14 08:58:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731443002/40001
6 years, 1 month ago (2014-11-14 08:58:50 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 10:50:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185364

Powered by Google App Engine
This is Rietveld 408576698