LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html - Issue 731443002: [LayoutTest] Fix xmlhttprequest-responseXML-nopartial flakiness.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-responseXML-nopartial.html

Issue 731443002: [LayoutTest] Fix xmlhttprequest-responseXML-nopartial flakiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="/js-test-resources/js-test.js"></script>	2 <script src="/js-test-resources/js-test.js"></script>

3 <script>	3 <script>

4 jsTestIsAsync = true;	4 jsTestIsAsync = true;

5	5

6 var xhr = new XMLHttpRequest();	6 var xhr = new XMLHttpRequest();

7 xhr.responseType = 'document';	7 xhr.responseType = 'document';

8 xhr.onreadystatechange = function () {	8 xhr.onreadystatechange = function () {

9 if (this.readyState != XMLHttpRequest.DONE) {	9 if (this.readyState != XMLHttpRequest.DONE) {

10 // avoid showing PASS messages via shouldBeNull, as we have no guarantee how many 'readystatechange' we would receive.	10 // avoid showing PASS messages via shouldBeNull, as we have no guarantee how many 'readystatechange' we would receive.

11 if (xhr.responseXML !== null)	11 if (xhr.responseXML !== null)

12 testFailed("response HTML was visible before DONE")	12 testFailed("response HTML was visible before DONE")

13 return;	13 return;

14 }	14 }

15	15

16 shouldBeNonNull("xhr.responseXML");	16 shouldBeNonNull("xhr.responseXML");

17 testRunner.notifyDone();	17 testRunner.notifyDone();

18 }	18 }

19	19

20 xhr.open("GET", "resources/small-chunks.cgi", true);	20 xhr.open("GET", "resources/test.html", true);
	kouhei (in TOK) 2014/11/14 07:40:52 The reason I used small-chunks here is to test tha The reason I used small-chunks here is to test that no intermediate state is exposed to user Javascript. If we use "test.html", the response would be almost certainly delivered in a single chunk, so it would not serve as a test case. How about using smaller sleep time on small-chunks.cgi instead? yhirano 2014/11/14 08:56:56 Done. Show quoted text On 2014/11/14 07:40:52, kouhei wrote: > The reason I used small-chunks here is to test that no intermediate state is > exposed to user Javascript. > > If we use "test.html", the response would be almost certainly delivered in a > single chunk, so it would not serve as a test case. > > How about using smaller sleep time on small-chunks.cgi instead? Done.
21 xhr.send(null);	21 xhr.send(null);

22 </script>	22 </script>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »