Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: chrome/browser/content_settings/host_content_settings_map_unittest.cc

Issue 731373002: Enable MSVC warning for unused locals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another Windows fix Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | chrome/browser/enumerate_modules_model_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/host_content_settings_map_unittest.cc
diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
index 0018d7f43e6d67de1cbcaab26425e1d46cd94e11..498252904bc0abcd64bfc839ad373e25be7f4ea7 100644
--- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc
+++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
@@ -914,36 +914,32 @@ TEST_F(HostContentSettingsMapTest, GetContentSetting) {
}
TEST_F(HostContentSettingsMapTest, ShouldAllowAllContent) {
- TestingProfile profile;
- HostContentSettingsMap* host_content_settings_map =
- profile.GetHostContentSettingsMap();
-
GURL http_host("http://example.com/");
GURL https_host("https://example.com/");
GURL embedder("chrome://foo");
GURL extension("chrome-extension://foo");
- EXPECT_FALSE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_FALSE(HostContentSettingsMap::ShouldAllowAllContent(
http_host, embedder, CONTENT_SETTINGS_TYPE_NOTIFICATIONS));
- EXPECT_FALSE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_FALSE(HostContentSettingsMap::ShouldAllowAllContent(
http_host, embedder, CONTENT_SETTINGS_TYPE_GEOLOCATION));
- EXPECT_FALSE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_FALSE(HostContentSettingsMap::ShouldAllowAllContent(
http_host, embedder, CONTENT_SETTINGS_TYPE_COOKIES));
- EXPECT_TRUE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_TRUE(HostContentSettingsMap::ShouldAllowAllContent(
https_host, embedder, CONTENT_SETTINGS_TYPE_COOKIES));
- EXPECT_TRUE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_TRUE(HostContentSettingsMap::ShouldAllowAllContent(
https_host, embedder, CONTENT_SETTINGS_TYPE_COOKIES));
- EXPECT_TRUE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_TRUE(HostContentSettingsMap::ShouldAllowAllContent(
embedder, http_host, CONTENT_SETTINGS_TYPE_COOKIES));
#if defined(ENABLE_EXTENSIONS)
- EXPECT_TRUE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_TRUE(HostContentSettingsMap::ShouldAllowAllContent(
extension, extension, CONTENT_SETTINGS_TYPE_COOKIES));
#else
- EXPECT_FALSE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_FALSE(HostContentSettingsMap::ShouldAllowAllContent(
extension, extension, CONTENT_SETTINGS_TYPE_COOKIES));
#endif
- EXPECT_FALSE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_FALSE(HostContentSettingsMap::ShouldAllowAllContent(
extension, extension, CONTENT_SETTINGS_TYPE_PLUGINS));
- EXPECT_FALSE(host_content_settings_map->ShouldAllowAllContent(
+ EXPECT_FALSE(HostContentSettingsMap::ShouldAllowAllContent(
extension, http_host, CONTENT_SETTINGS_TYPE_COOKIES));
}
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | chrome/browser/enumerate_modules_model_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698