build/config/compiler/BUILD.gn - Issue 731373002: Enable MSVC warning for unused locals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 731373002: Enable MSVC warning for unused locals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another Windows fix Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 0d9e501a9be76fd4e19401b69a032bfb1bc61a18..ae12eda3ba7b556e4c7f0a0b25e71ccd767995fc 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -691,7 +691,6 @@ config("default_warnings") {

"/wd4100", # Unreferenced formal function parameter.

"/wd4121", # Alignment of a member was sensitive to packing.

- "/wd4189", # A variable was declared and initialized but never used.

"/wd4244", # Conversion: possible loss of data.

"/wd4481", # Nonstandard extension: override specifier.

"/wd4505", # Unreferenced local function has been removed.