[Extensions Toolbar] Notify observers of extensions re-added after a pref change

chrome/browser/extensions/extension_toolbar_model.h

Index: chrome/browser/extensions/extension_toolbar_model.h
diff --git a/chrome/browser/extensions/extension_toolbar_model.h b/chrome/browser/extensions/extension_toolbar_model.h
index fe38a6ba3b3002d0ffe2653bb37ef44e10da54c8..867ee67f5f08f8978f6bce1d3a2108e48d5eaae2 100644
--- a/chrome/browser/extensions/extension_toolbar_model.h
+++ b/chrome/browser/extensions/extension_toolbar_model.h
@@ -224,9 +224,6 @@ class ExtensionToolbarModel : public content::NotificationObserver,
   void AddExtension(const Extension* extension);
   void RemoveExtension(const Extension* extension);
 
-  // Removes all current items (because we're going to [re]Populate()).
-  void ClearItems();

[Marijn Kruisselbrink, 2014/11/17 22:18:02]

Just curious what changed that before you had this as a separate method, and now
you inlined it in OnExtensionToolbarPrefChange?

[Devlin, 2014/11/17 22:44:13]

At one point, it was called multiple times; now that we only use it in the one
place, it seems kind of silly to have it separate (since it's only 4 lines). 
Also, I think it makes the add/remove in the pref update more clear.

-
   // Our observers.
   ObserverList<Observer> observers_;