[Extensions Toolbar] Notify observers of extensions re-added after a pref change

chrome/browser/extensions/extension_toolbar_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_
 
 #include "base/compiler_specific.h"
 #include "base/observer_list.h"
 #include "base/prefs/pref_change_registrar.h"
@@ skipping 206 matching lines @@
   // value returned is a zero-based index into the vector of visible items.
   size_t FindNewPositionFromLastKnownGood(const Extension* extension);
 
   // Returns true if the given |extension| should be added to the toolbar.
   bool ShouldAddExtension(const Extension* extension);
 
   // Adds or removes the given |extension| from the toolbar model.
   void AddExtension(const Extension* extension);
   void RemoveExtension(const Extension* extension);
 
-  // Removes all current items (because we're going to [re]Populate()).
-  void ClearItems();

[Marijn Kruisselbrink, 2014/11/17 22:18:02]

Just curious what changed that before you had this as a separate method, and now
you inlined it in OnExtensionToolbarPrefChange?

[Devlin, 2014/11/17 22:44:13]

At one point, it was called multiple times; now that we only use it in the one
place, it seems kind of silly to have it separate (since it's only 4 lines). 
Also, I think it makes the add/remove in the pref update more clear.

-
   // Our observers.
   ObserverList<Observer> observers_;
 
   // The Profile this toolbar model is for.
   Profile* profile_;
 
   ExtensionPrefs* extension_prefs_;
   PrefService* prefs_;
 
   // True if we've handled the initial EXTENSIONS_READY notification.
@@ skipping 42 matching lines @@
   base::Closure pref_change_callback_;
 
   base::WeakPtrFactory<ExtensionToolbarModel> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionToolbarModel);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_