Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 731353002: [Extensions Toolbar] Notify observers of extensions re-added after a pref change (Closed)

Created:
6 years, 1 month ago by Devlin
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar] Notify observers of extensions re-added after a pref change I suspect this is what's causing the listed bugs, as it would lead to the observers' lists getting out of order. BUG=433757 BUG=433764 Committed: https://crrev.com/ad3ae498cb192d7a78c8efdc053d5d22c8713a1d Cr-Commit-Position: refs/heads/master@{#304519}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Marijn's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -15 lines) Patch
M chrome/browser/extensions/extension_toolbar_model.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 2 chunks +16 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
6 years, 1 month ago (2014-11-17 21:47:29 UTC) #3
Marijn Kruisselbrink
lgtm https://codereview.chromium.org/731353002/diff/20001/chrome/browser/extensions/extension_toolbar_model.cc File chrome/browser/extensions/extension_toolbar_model.cc (right): https://codereview.chromium.org/731353002/diff/20001/chrome/browser/extensions/extension_toolbar_model.cc#newcode570 chrome/browser/extensions/extension_toolbar_model.cc:570: for (size_t i = 0; i < items_count; ...
6 years, 1 month ago (2014-11-17 22:18:02 UTC) #4
Devlin
https://codereview.chromium.org/731353002/diff/20001/chrome/browser/extensions/extension_toolbar_model.cc File chrome/browser/extensions/extension_toolbar_model.cc (right): https://codereview.chromium.org/731353002/diff/20001/chrome/browser/extensions/extension_toolbar_model.cc#newcode570 chrome/browser/extensions/extension_toolbar_model.cc:570: for (size_t i = 0; i < items_count; ++i) ...
6 years, 1 month ago (2014-11-17 22:44:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731353002/40001
6 years, 1 month ago (2014-11-17 22:45:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-17 23:37:39 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 23:38:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad3ae498cb192d7a78c8efdc053d5d22c8713a1d
Cr-Commit-Position: refs/heads/master@{#304519}

Powered by Google App Engine
This is Rietveld 408576698