Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: examples/apptest/example_service_impl.h

Issue 731293003: Use Binding instead of InterfaceImpl for ExampleService. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Simplify ExampleClientImpl. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: examples/apptest/example_service_impl.h
diff --git a/examples/apptest/example_service_impl.h b/examples/apptest/example_service_impl.h
index 7c6138a0190aabe16b70d0e7441222e6ec1269bf..1f133559fd026c76ff2d1bfbf8281c97a9c7570e 100644
--- a/examples/apptest/example_service_impl.h
+++ b/examples/apptest/example_service_impl.h
@@ -12,15 +12,17 @@ namespace mojo {
class ApplicationConnection;
-class ExampleServiceImpl : public InterfaceImpl<ExampleService> {
+class ExampleServiceImpl : public ExampleService {
public:
- ExampleServiceImpl();
- virtual ~ExampleServiceImpl();
+ explicit ExampleServiceImpl(mojo::InterfaceRequest<ExampleService> request);
jamesr 2014/11/17 22:33:04 this code is in namespace mojo, don't say mojo:: a
msw 2014/11/17 23:05:32 Done.
+ ~ExampleServiceImpl() override;
private:
- // InterfaceImpl<ExampleService> overrides.
- virtual void Ping(uint16_t ping_value) override;
- virtual void RunCallback(const Callback<void()>& callback) override;
+ // ExampleService overrides.
+ void Ping(uint16_t ping_value) override;
+ void RunCallback(const Callback<void()>& callback) override;
+
+ mojo::Binding<ExampleService> binding_;
jamesr 2014/11/17 22:33:04 no mojo:: if you want this object to delete itsel
msw 2014/11/17 23:05:32 Done.
MOJO_DISALLOW_COPY_AND_ASSIGN(ExampleServiceImpl);
};

Powered by Google App Engine
This is Rietveld 408576698