Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: examples/apptest/example_service_impl.h

Issue 731293003: Use Binding instead of InterfaceImpl for ExampleService. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Simplify ExampleClientImpl. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_EXAMPLES_TEST_EXAMPLE_SERVICE_IMPL_H_ 5 #ifndef MOJO_EXAMPLES_TEST_EXAMPLE_SERVICE_IMPL_H_
6 #define MOJO_EXAMPLES_TEST_EXAMPLE_SERVICE_IMPL_H_ 6 #define MOJO_EXAMPLES_TEST_EXAMPLE_SERVICE_IMPL_H_
7 7
8 #include "examples/apptest/example_service.mojom.h" 8 #include "examples/apptest/example_service.mojom.h"
9 #include "mojo/public/cpp/system/macros.h" 9 #include "mojo/public/cpp/system/macros.h"
10 10
11 namespace mojo { 11 namespace mojo {
12 12
13 class ApplicationConnection; 13 class ApplicationConnection;
14 14
15 class ExampleServiceImpl : public InterfaceImpl<ExampleService> { 15 class ExampleServiceImpl : public ExampleService {
16 public: 16 public:
17 ExampleServiceImpl(); 17 explicit ExampleServiceImpl(mojo::InterfaceRequest<ExampleService> request);
jamesr 2014/11/17 22:33:04 this code is in namespace mojo, don't say mojo:: a
msw 2014/11/17 23:05:32 Done.
18 virtual ~ExampleServiceImpl(); 18 ~ExampleServiceImpl() override;
19 19
20 private: 20 private:
21 // InterfaceImpl<ExampleService> overrides. 21 // ExampleService overrides.
22 virtual void Ping(uint16_t ping_value) override; 22 void Ping(uint16_t ping_value) override;
23 virtual void RunCallback(const Callback<void()>& callback) override; 23 void RunCallback(const Callback<void()>& callback) override;
24
25 mojo::Binding<ExampleService> binding_;
jamesr 2014/11/17 22:33:04 no mojo:: if you want this object to delete itsel
msw 2014/11/17 23:05:32 Done.
24 26
25 MOJO_DISALLOW_COPY_AND_ASSIGN(ExampleServiceImpl); 27 MOJO_DISALLOW_COPY_AND_ASSIGN(ExampleServiceImpl);
26 }; 28 };
27 29
28 } // namespace mojo 30 } // namespace mojo
29 31
30 #endif // MOJO_EXAMPLES_TEST_EXAMPLE_SERVICE_IMPL_H_ 32 #endif // MOJO_EXAMPLES_TEST_EXAMPLE_SERVICE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698