Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add various unittests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/shared_page_state.py
diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py
index b02bba84b347ded95699d45f99b0d9cb5c3742d6..98dd37d1d3fd07469f8d26a7068df68f9b08108a 100644
--- a/tools/telemetry/telemetry/page/shared_page_state.py
+++ b/tools/telemetry/telemetry/page/shared_page_state.py
@@ -13,6 +13,7 @@ from telemetry.core import util
from telemetry.core import wpr_modes
from telemetry.page import page_test
from telemetry.util import file_handle
+from telemetry.value import profiler
from telemetry.value import skip
from telemetry.core.platform.profiler import profiler_finder
@@ -256,5 +257,6 @@ class SharedPageState(object):
profiler_files = self.platform.profiling_controller.Stop()
for f in profiler_files:
if os.path.isfile(f):
- results.AddProfilingFile(self._current_page,
- file_handle.FromFilePath(f))
+ results.AddValue(profiler.ProfilerValue(self._current_page,
+ self._finder_options.profiler,
+ file_handle.FromFilePath(f)))

Powered by Google App Engine
This is Rietveld 408576698