Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add various unittests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py
index 51d540a6bce475d29f17f7989ca39230413adc43..fe554ddb403eddb96a6f3a376b0189621d52058d 100644
--- a/tools/telemetry/telemetry/page/page_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py
@@ -25,6 +25,7 @@ from telemetry.results import results_options
from telemetry.unittest_util import options_for_unittests
from telemetry.unittest_util import system_stub
from telemetry.util import exception_formatter as exception_formatter_module
+from telemetry.value import profiler
from telemetry.value import scalar
from telemetry.value import string
@@ -659,7 +660,11 @@ class PageRunnerTests(unittest.TestCase):
page_runner.Run(Measurement(), ps, expectations, options, results)
self.assertEquals(1, len(GetSuccessfulPageRuns(results)))
self.assertEquals(0, len(results.failures))
- self.assertEquals(0, len(results.all_page_specific_values))
+ self.assertEquals(1, len(results.all_page_specific_values))
+ self.assertTrue(isinstance(results.all_page_specific_values[0],
+ profiler.ProfilerValue))
+ self.assertEquals(results.all_page_specific_values[0].profiler_name,
+ 'trace')
self.assertTrue(os.path.isfile(
os.path.join(options.output_dir, 'blank_html.json')))
finally:

Powered by Google App Engine
This is Rietveld 408576698