Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: tools/telemetry/telemetry/value/trace_unittest.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ready to submit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/trace.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/trace_unittest.py
diff --git a/tools/telemetry/telemetry/value/trace_unittest.py b/tools/telemetry/telemetry/value/trace_unittest.py
index 6c9bda41584725dcd1301c29489ba97f22a43be2..f2f991ba7ad11b848a708c362ea484bd7f6d63fd 100644
--- a/tools/telemetry/telemetry/value/trace_unittest.py
+++ b/tools/telemetry/telemetry/value/trace_unittest.py
@@ -7,6 +7,7 @@ import unittest
from telemetry.page import page_set
from telemetry.timeline import tracing_timeline_data
+from telemetry.unittest_util import system_stub
from telemetry.value import trace
class TestBase(unittest.TestCase):
@@ -16,6 +17,13 @@ class TestBase(unittest.TestCase):
self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/")
self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/")
+ self._cloud_storage_stub = system_stub.Override(trace, ['cloud_storage'])
+
+ def tearDown(self):
+ if self._cloud_storage_stub:
+ self._cloud_storage_stub.Restore()
+ self._cloud_storage_stub = None
+
@property
def pages(self):
return self.page_set.pages
@@ -24,8 +32,11 @@ class ValueTest(TestBase):
def testAsDict(self):
v = trace.TraceValue(
None, tracing_timeline_data.TracingTimelineData({'test' : 1}))
- fh_id = v.GetAssociatedFileHandle().id
-
+ fh = v.GetAssociatedFileHandle()
+ trace.cloud_storage.SetCalculatedHashesForTesting(
+ {fh.GetAbsPath(): 123, })
+ bucket = trace.cloud_storage.PUBLIC_BUCKET
+ cloud_url = v.UploadToCloud(bucket)
d = v.AsDict()
-
- self.assertEqual(d['file_id'], fh_id)
+ self.assertEqual(d['file_id'], fh.id)
+ self.assertEqual(d['cloud_url'], cloud_url)
« no previous file with comments | « tools/telemetry/telemetry/value/trace.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698