tools/telemetry/telemetry/value/trace.py - Issue 731233003: Format profiler/trace files cloud url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/trace.py

Issue 731233003: Format profiler/trace files cloud url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to submit Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/value/trace.py

diff --git a/tools/telemetry/telemetry/value/trace.py b/tools/telemetry/telemetry/value/trace.py

index 643f51578fd0bd02bd99b1eeaaba4144f112a63e..70a85ca7432e0ce2f6b3ea69f78df4507ed0b4f8 100644

--- a/tools/telemetry/telemetry/value/trace.py

+++ b/tools/telemetry/telemetry/value/trace.py

@@ -82,6 +82,8 @@ class TraceValue(value_module.Value):

def AsDict(self):

d = super(TraceValue, self).AsDict()

d['file_id'] = self._file_handle.id

+ if self._cloud_url:

+ d['cloud_url'] = self._cloud_url

return d

def UploadToCloud(self, bucket):

@@ -97,6 +99,7 @@ class TraceValue(value_module.Value):

sys.stderr.write(

'View generated trace files online at %s for page %s\n' %

(self._cloud_url, self.page.url if self.page else 'unknown'))

+ return self._cloud_url

except cloud_storage.PermissionError as e:

logging.error('Cannot upload trace files to cloud storage due to '

' permission error: %s' % e.message)