Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3196)

Unified Diff: chrome/browser/ui/blocked_content/blocked_window_params.cc

Issue 731083002: Update popup blocker behavior and tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/blocked_content/blocked_window_params.cc
diff --git a/chrome/browser/ui/blocked_content/blocked_window_params.cc b/chrome/browser/ui/blocked_content/blocked_window_params.cc
index c26a42b0417fff0e7964bfe26db0db10138e32d1..62e6d2f24f04a563f5176677385fa513315d65a4 100644
--- a/chrome/browser/ui/blocked_content/blocked_window_params.cc
+++ b/chrome/browser/ui/blocked_content/blocked_window_params.cc
@@ -55,11 +55,7 @@ chrome::NavigateParams BlockedWindowParams::CreateNavigateParams(
if (features_.heightSet)
nav_params.window_bounds.set_height(features_.height);
- // Compare RenderViewImpl::show().
- if (!user_gesture_ && disposition_ != NEW_BACKGROUND_TAB)
- nav_params.disposition = NEW_POPUP;
- else
- nav_params.disposition = disposition_;
+ nav_params.disposition = disposition_;
return nav_params;
}
« no previous file with comments | « no previous file | chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698