Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: sky/engine/core/rendering/RenderView.cpp

Issue 730653002: Sky: update the HTMLIFrameElement's geometry during paint invalidation rather (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: esprehn Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderView.cpp
diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp
index beb07ac23d3d953a508e91643f8a6b864f345430..44a01efe65b1f1a8916082d4a1254132ede607a1 100644
--- a/sky/engine/core/rendering/RenderView.cpp
+++ b/sky/engine/core/rendering/RenderView.cpp
@@ -299,6 +299,11 @@ void RenderView::invalidateTreeIfNeeded(const PaintInvalidationState& paintInval
const RenderLayerModelObject* paintInvalidationContainer = &paintInvalidationState.paintInvalidationContainer();
mapRectToPaintInvalidationBacking(paintInvalidationContainer, dirtyRect, &paintInvalidationState);
invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRect, InvalidationFull);
+
+ // Also need to handle iframes, since they have a separate view outside
+ // the hierarchy.
+ for (auto& iframe: m_iframes)
+ iframe->invalidateWidgetBounds();
esprehn 2014/11/17 19:04:32 We don't always repaint if you move, for example i
}
RenderBlock::invalidateTreeIfNeeded(paintInvalidationState);
}
@@ -754,4 +759,14 @@ double RenderView::layoutViewportHeight() const
return viewHeight(IncludeScrollbars);
}
+void RenderView::addIFrame(RenderIFrame* iframe)
+{
+ m_iframes.add(iframe);
+}
+
+void RenderView::removeIFrame(RenderIFrame* iframe)
+{
+ m_iframes.remove(iframe);
+}
+
} // namespace blink
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698