Sky: update the HTMLIFrameElement's geometry during paint invalidation rather

sky/engine/core/rendering/RenderView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 281 matching lines @@
 {
     ASSERT(!needsLayout());
 
     // We specifically need to issue paint invalidations for the viewRect since other renderers
     // short-circuit on full-paint invalidation.
     LayoutRect dirtyRect = viewRect();
     if (doingFullPaintInvalidation() && !dirtyRect.isEmpty()) {
         const RenderLayerModelObject* paintInvalidationContainer = &paintInvalidationState.paintInvalidationContainer();
         mapRectToPaintInvalidationBacking(paintInvalidationContainer, dirtyRect, &paintInvalidationState);
         invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRect, InvalidationFull);
+
+        // Also need to handle iframes, since they have a separate view outside
+        // the hierarchy.
+        for (auto& iframe: m_iframes)
+            iframe->invalidateWidgetBounds();

[esprehn, 2014/11/17 19:04:32]

We don't always repaint if you move, for example if you give the iframe
translateZ(0) today then we'll not repaint if you transform it which means we'll
never get here.

I think this needs to be an explicit step the
FrameView::updateStyleAndLayoutForPainting() process.

     }
     RenderBlock::invalidateTreeIfNeeded(paintInvalidationState);
 }
 
 void RenderView::invalidatePaintForRectangle(const LayoutRect& paintInvalidationRect) const
 {
     ASSERT(!paintInvalidationRect.isEmpty());
 
     if (!m_frameView)
         return;
@@ skipping 435 matching lines @@
 {
     return viewWidth(IncludeScrollbars);
 }
 
 // FIXME(sky): remove
 double RenderView::layoutViewportHeight() const
 {
     return viewHeight(IncludeScrollbars);
 }
 
+void RenderView::addIFrame(RenderIFrame* iframe)
+{
+    m_iframes.add(iframe);
+}
+
+void RenderView::removeIFrame(RenderIFrame* iframe)
+{
+    m_iframes.remove(iframe);
+}
+
 } // namespace blink