Sky: update the HTMLIFrameElement's geometry during paint invalidation rather

sky/engine/core/rendering/RenderView.cpp

Index: sky/engine/core/rendering/RenderView.cpp
diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp
index beb07ac23d3d953a508e91643f8a6b864f345430..b21f96729fd6e463e59a8d6c189b811a54249c5f 100644
--- a/sky/engine/core/rendering/RenderView.cpp
+++ b/sky/engine/core/rendering/RenderView.cpp
@@ -299,6 +299,13 @@ void RenderView::invalidateTreeIfNeeded(const PaintInvalidationState& paintInval
         const RenderLayerModelObject* paintInvalidationContainer = &paintInvalidationState.paintInvalidationContainer();
         mapRectToPaintInvalidationBacking(paintInvalidationContainer, dirtyRect, &paintInvalidationState);
         invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRect, InvalidationFull);
+
+        // Also need to handle iframes, since they have a separate view outside
+        // the hierarchy.
+        WTF::Vector<RenderIFrame*> iframes;
+        copyToVector(m_iframes, iframes);
+        for (size_t i = 0; i < iframes.size(); ++i)

[esprehn, 2014/11/14 21:46:08]

You don't need to copy to a Vector, there's no synchronous script in there, just
use the iterator on the HashSet.

This also doesn't seem right, if we fully invalidate the entire viewport we
might not even get here. You want this to be a separate and explicit step inside
FrameView::updateLayoutAndStyleForPainting() like updateIframeBoundsIfNeeded();

[Matt Perry, 2014/11/14 22:03:34]

Done.
I don't follow you here. This is only for the case where we're invalidating the
whole viewport - e.g., doingFullPaintInvalidation(). In the case where that is
false, we instead crawl down the render tree and invalidate each individual
iframe if it's part of a subtree that was invalidated.
(RenderObject::invalidatePaintIfNeeded)

+            iframes[i]->invalidateWidgetBounds();
     }
     RenderBlock::invalidateTreeIfNeeded(paintInvalidationState);
 }
@@ -754,4 +761,14 @@ double RenderView::layoutViewportHeight() const
     return viewHeight(IncludeScrollbars);
 }
 
+void RenderView::addIFrame(RenderIFrame* iframe)
+{
+    m_iframes.add(iframe);
+}
+
+void RenderView::removeIFrame(RenderIFrame* iframe)
+{
+    m_iframes.remove(iframe);
+}
+
 } // namespace blink