Sky: update the HTMLIFrameElement's geometry during paint invalidation rather

sky/engine/core/rendering/RenderView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 281 matching lines @@
 {
     ASSERT(!needsLayout());
 
     // We specifically need to issue paint invalidations for the viewRect since other renderers
     // short-circuit on full-paint invalidation.
     LayoutRect dirtyRect = viewRect();
     if (doingFullPaintInvalidation() && !dirtyRect.isEmpty()) {
         const RenderLayerModelObject* paintInvalidationContainer = &paintInvalidationState.paintInvalidationContainer();
         mapRectToPaintInvalidationBacking(paintInvalidationContainer, dirtyRect, &paintInvalidationState);
         invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRect, InvalidationFull);
+
+        // Also need to handle iframes, since they have a separate view outside
+        // the hierarchy.
+        WTF::Vector<RenderIFrame*> iframes;
+        copyToVector(m_iframes, iframes);
+        for (size_t i = 0; i < iframes.size(); ++i)

[esprehn, 2014/11/14 21:46:08]

You don't need to copy to a Vector, there's no synchronous script in there, just
use the iterator on the HashSet.

This also doesn't seem right, if we fully invalidate the entire viewport we
might not even get here. You want this to be a separate and explicit step inside
FrameView::updateLayoutAndStyleForPainting() like updateIframeBoundsIfNeeded();

[Matt Perry, 2014/11/14 22:03:34]

Done.
I don't follow you here. This is only for the case where we're invalidating the
whole viewport - e.g., doingFullPaintInvalidation(). In the case where that is
false, we instead crawl down the render tree and invalidate each individual
iframe if it's part of a subtree that was invalidated.
(RenderObject::invalidatePaintIfNeeded)

+            iframes[i]->invalidateWidgetBounds();
     }
     RenderBlock::invalidateTreeIfNeeded(paintInvalidationState);
 }
 
 void RenderView::invalidatePaintForRectangle(const LayoutRect& paintInvalidationRect) const
 {
     ASSERT(!paintInvalidationRect.isEmpty());
 
     if (!m_frameView)
         return;
@@ skipping 435 matching lines @@
 {
     return viewWidth(IncludeScrollbars);
 }
 
 // FIXME(sky): remove
 double RenderView::layoutViewportHeight() const
 {
     return viewHeight(IncludeScrollbars);
 }
 
+void RenderView::addIFrame(RenderIFrame* iframe)
+{
+    m_iframes.add(iframe);
+}
+
+void RenderView::removeIFrame(RenderIFrame* iframe)
+{
+    m_iframes.remove(iframe);
+}
+
 } // namespace blink