Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 730573002: Remove dead code for system VK. (Closed)

Created:
6 years, 1 month ago by kevers
Modified:
6 years, 1 month ago
Reviewers:
pkotwicz
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove dead code for system VK. BUG=401729 Committed: https://crrev.com/b5449cade5dd8336392b21580e698cdbf0f5b981 Cr-Commit-Position: refs/heads/master@{#304225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5178 lines) Patch
D ui/keyboard/resources/api_adapter.js View 1 chunk +0 lines, -76 lines 0 comments Download
D ui/keyboard/resources/constants.js View 1 chunk +0 lines, -113 lines 0 comments Download
D ui/keyboard/resources/elements/kb-altkey.html View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/keyboard/resources/elements/kb-altkey.js View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/keyboard/resources/elements/kb-altkey-container.html View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/keyboard/resources/elements/kb-altkey-container.js View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/keyboard/resources/elements/kb-altkey-data.html View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/keyboard/resources/elements/kb-altkey-data.js View 1 chunk +0 lines, -126 lines 0 comments Download
D ui/keyboard/resources/elements/kb-altkey-set.html View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/keyboard/resources/elements/kb-altkey-set.js View 1 chunk +0 lines, -10 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key.html View 1 chunk +0 lines, -116 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key.js View 1 chunk +0 lines, -114 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key-base.html View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key-base.js View 1 chunk +0 lines, -228 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key-codes.html View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key-codes.js View 1 chunk +0 lines, -227 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key-import.html View 1 chunk +0 lines, -15 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key-import.js View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key-sequence.html View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/keyboard/resources/elements/kb-key-sequence.js View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/keyboard/resources/elements/kb-keyboard.html View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/keyboard/resources/elements/kb-keyboard.js View 1 chunk +0 lines, -977 lines 0 comments Download
D ui/keyboard/resources/elements/kb-keyset.html View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/keyboard/resources/elements/kb-keyset.js View 1 chunk +0 lines, -104 lines 0 comments Download
D ui/keyboard/resources/elements/kb-modifier-key.html View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/keyboard/resources/elements/kb-modifier-key.js View 1 chunk +0 lines, -135 lines 0 comments Download
D ui/keyboard/resources/elements/kb-row.html View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/keyboard/resources/elements/kb-row.js View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/keyboard/resources/elements/kb-shift-key.html View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/keyboard/resources/elements/kb-shift-key.js View 1 chunk +0 lines, -246 lines 0 comments Download
D ui/keyboard/resources/images/back.svg View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/keyboard/resources/images/backspace.png View Binary file 0 comments Download
D ui/keyboard/resources/images/brightness-down.svg View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/keyboard/resources/images/brightness-up.svg View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/keyboard/resources/images/change-window.svg View 1 chunk +0 lines, -33 lines 0 comments Download
D ui/keyboard/resources/images/chevron.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/keyboard/resources/images/del.svg View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/keyboard/resources/images/down.svg View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/keyboard/resources/images/forward.svg View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/keyboard/resources/images/fullscreen.svg View 1 chunk +0 lines, -37 lines 0 comments Download
D ui/keyboard/resources/images/hide-keyboard.png View Binary file 0 comments Download
D ui/keyboard/resources/images/left.svg View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/keyboard/resources/images/reload.svg View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/keyboard/resources/images/return.png View Binary file 0 comments Download
D ui/keyboard/resources/images/right.svg View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/keyboard/resources/images/search.png View Binary file 0 comments Download
D ui/keyboard/resources/images/shift.png View Binary file 0 comments Download
D ui/keyboard/resources/images/shutdown.svg View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/keyboard/resources/images/tab.png View Binary file 0 comments Download
D ui/keyboard/resources/images/up.svg View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/keyboard/resources/images/volume-down.svg View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/keyboard/resources/images/volume-up.svg View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/keyboard/resources/keyboard.js View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/keyboard/resources/layouts/dvorak.html View 1 chunk +0 lines, -139 lines 0 comments Download
D ui/keyboard/resources/layouts/function-key-row.html View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/keyboard/resources/layouts/latin-accents.js View 1 chunk +0 lines, -81 lines 0 comments Download
D ui/keyboard/resources/layouts/numeric.html View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/keyboard/resources/layouts/qwerty.html View 1 chunk +0 lines, -145 lines 0 comments Download
D ui/keyboard/resources/layouts/spacebar-row.html View 1 chunk +0 lines, -10 lines 0 comments Download
D ui/keyboard/resources/layouts/symbol-altkeys.js View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/keyboard/resources/layouts/system-qwerty.html View 1 chunk +0 lines, -111 lines 0 comments Download
D ui/keyboard/resources/main.css View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/keyboard/resources/main.js View 1 chunk +0 lines, -636 lines 0 comments Download
D ui/keyboard/resources/polymer_loader.js View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/keyboard/resources/sounds/keypress-delete.wav View Binary file 0 comments Download
D ui/keyboard/resources/sounds/keypress-return.wav View Binary file 0 comments Download
D ui/keyboard/resources/sounds/keypress-spacebar.wav View Binary file 0 comments Download
D ui/keyboard/resources/sounds/keypress-standard.wav View Binary file 0 comments Download
D ui/keyboard/resources/touch_fuzzing.js View 1 chunk +0 lines, -453 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kevers
Peter, PTAL
6 years, 1 month ago (2014-11-14 15:57:21 UTC) #2
pkotwicz
lgtm
6 years, 1 month ago (2014-11-14 15:59:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730573002/1
6 years, 1 month ago (2014-11-14 16:01:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-14 16:42:54 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 16:44:02 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b5449cade5dd8336392b21580e698cdbf0f5b981
Cr-Commit-Position: refs/heads/master@{#304225}

Powered by Google App Engine
This is Rietveld 408576698