Source/core/css/resolver/StyleResolver.h - Issue 730513002: Should remove ScopedStyleResolver when ShadowRoot is removed from docoument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolver.h

Issue 730513002: Should remove ScopedStyleResolver when ShadowRoot is removed from docoument. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP: Fixed the issue. Tested manually. Need layout test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleResolver.h

diff --git a/Source/core/css/resolver/StyleResolver.h b/Source/core/css/resolver/StyleResolver.h

index fa5e8d789d5ed7b75f0735cc8e4e0e890e51c80d..7d7e42433dd3d21302726149efad354f9bcbcd4a 100644

--- a/Source/core/css/resolver/StyleResolver.h

+++ b/Source/core/css/resolver/StyleResolver.h

@@ -124,8 +124,6 @@ public:

void resetAuthorStyle(TreeScope&);

void finishAppendAuthorStyleSheets();

- void processScopedRules(const RuleSet& authorRules, CSSStyleSheet*, unsigned sheetIndex, ContainerNode& scope);

void lazyAppendAuthorStyleSheets(unsigned firstNew, const WillBeHeapVector<RefPtrWillBeMember<CSSStyleSheet> >&);

void removePendingAuthorStyleSheets(const WillBeHeapVector<RefPtrWillBeMember<CSSStyleSheet> >&);

void appendPendingAuthorStyleSheets();

@@ -213,6 +211,7 @@ private:

void appendCSSStyleSheet(CSSStyleSheet&);

void addRulesFromSheet(CSSStyleSheet&, TreeScope*, unsigned);

+ void processScopedRules(const RuleSet& authorRules, CSSStyleSheet*, unsigned sheetIndex, ContainerNode& scope);

void collectPseudoRulesForElement(Element*, ElementRuleCollector&, PseudoId, unsigned rulesToInclude);

void matchRuleSet(ElementRuleCollector&, RuleSet*);

« no previous file with comments | « no previous file | Source/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »