Source/core/css/resolver/StyleResolver.cpp - Issue 730513002: Should remove ScopedStyleResolver when ShadowRoot is removed from docoument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 730513002: Should remove ScopedStyleResolver when ShadowRoot is removed from docoument. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP: Fixed the issue. Tested manually. Need layout test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleResolver.cpp

diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp

index 5658520f8fb0fdbcab0a7b8638e1ab77f5c054b5..35c9234abe92a199b6d43ba578c08fbbffbbedff 100644

--- a/Source/core/css/resolver/StyleResolver.cpp

+++ b/Source/core/css/resolver/StyleResolver.cpp

@@ -239,7 +239,6 @@ void StyleResolver::processScopedRules(const RuleSet& authorRules, CSSStyleSheet

{

const WillBeHeapVector<RawPtrWillBeMember<StyleRuleKeyframes> > keyframesRules = authorRules.keyframesRules();

ScopedStyleResolver* resolver = &scope.treeScope().ensureScopedStyleResolver();

- document().styleEngine()->addScopedStyleResolver(resolver);

for (unsigned i = 0; i < keyframesRules.size(); ++i)

resolver->addKeyframeStyle(keyframesRules[i]);

« no previous file with comments | « Source/core/css/resolver/StyleResolver.h ('k') | Source/core/dom/ProcessingInstruction.cpp » ('j') | no next file with comments »