BrowserCdmManager: gets RenderFrameHost instance on the correct thread.

BrowserCdmManager: gets RenderFrameHost instance on the correct thread.

This does not work if task_runner_ is not the browser UI thread.

R=xhwang@chromium.org
BUG=388930
TEST=manually verified EME playback

Committed: https://crrev.com/0623ac9bb431ada04f0f2558ca032188e2360324
Cr-Commit-Position: refs/heads/master@{#306907}

[gunsch, 2014-11-17 16:57:33]

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
File content/browser/media/cdm/browser_cdm_manager.cc (right):

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.cc:228:
->HasSwitch(switches::kDisableInfobarForProtectedMediaIdentifier)) {
somewhat related: is there any particular reason this flag is guarded with
OS_ANDROID? Since we enable this for Chromecast across the board, it would save
us the hop to the UI thread that will end up just calling
CreateSessionIfPermitted(..., true) anyways if we could enable that flag.

[xhwang, 2014-11-17 23:38:17]

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
File content/browser/media/cdm/browser_cdm_manager.cc (right):

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.cc:228:
->HasSwitch(switches::kDisableInfobarForProtectedMediaIdentifier)) {
On 2014/11/17 16:57:33, gunsch wrote:
> somewhat related: is there any particular reason this flag is guarded with
> OS_ANDROID? Since we enable this for Chromecast across the board, it would
save
> us the hop to the UI thread that will end up just calling
> CreateSessionIfPermitted(..., true) anyways if we could enable that flag.

I guess it's because this flag is only defined on Android:
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/media_s...

If you find this useful on other platforms, feel free to fix it.

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.cc:270: init_data);
Can you do the thread check and post within RequestSessionPermission()? This
function is already too long...

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.cc:367:
DCHECK_CURRENTLY_ON(BrowserThread::UI);
See comment above. Check thread and post RequestSessionPermission() if we are
not on the right thread.

[gunsch, 2014-11-19 21:59:01]

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
File content/browser/media/cdm/browser_cdm_manager.cc (right):

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.cc:270: init_data);
On 2014/11/17 23:38:17, xhwang wrote:
> Can you do the thread check and post within RequestSessionPermission()? This
> function is already too long...

Done.

https://codereview.chromium.org/730453004/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.cc:367:
DCHECK_CURRENTLY_ON(BrowserThread::UI);
On 2014/11/17 23:38:17, xhwang wrote:
> See comment above. Check thread and post RequestSessionPermission() if we are
> not on the right thread.

Done.

[gunsch, 2014-12-04 01:53:19]

ping? thanks

[xhwang, 2014-12-04 21:18:21]

lgtm

[gunsch, 2014-12-04 21:24:45]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-12-04 21:26:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/730453004/20001

[commit-bot: I haz the power, 2014-12-04 22:20:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-04 22:20:47]

Patchset 2 (id:??) landed as
https://crrev.com/0623ac9bb431ada04f0f2558ca032188e2360324
Cr-Commit-Position: refs/heads/master@{#306907}