Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 730083002: [media/audio] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
Reviewers:
xhwang, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[media/audio] Convert VLOGs to DVLOGs BUG=101424 Committed: https://crrev.com/9fb5e02a1616266d51c25a4ae1c72d698597a5a2 Cr-Commit-Position: refs/heads/master@{#304772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -80 lines) Patch
M media/audio/android/audio_android_unittest.cc View 15 chunks +26 lines, -26 lines 0 comments Download
M media/audio/audio_manager_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M media/audio/win/audio_device_listener_win.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 13 chunks +21 lines, -21 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-17 13:45:53 UTC) #2
xhwang
lgtm +dalecurtis FYI
6 years, 1 month ago (2014-11-17 19:33:58 UTC) #3
miu
Replaced myself w/ dalecurtis@ as he's more appropriate for reviewing the files being changed (or ...
6 years, 1 month ago (2014-11-17 20:46:48 UTC) #5
anujsharma
Thanks xhwang for lgtm. Shall i wait for Dalecurtis to review or go ahead with ...
6 years, 1 month ago (2014-11-18 13:08:52 UTC) #6
DaleCurtis
Oh, didn't realize you were waiting for me, lgtm
6 years, 1 month ago (2014-11-18 18:22:02 UTC) #7
anujsharma
On 2014/11/18 18:22:02, DaleCurtis wrote: > Oh, didn't realize you were waiting for me, lgtm ...
6 years, 1 month ago (2014-11-19 03:05:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730083002/1
6 years, 1 month ago (2014-11-19 03:07:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/13323)
6 years, 1 month ago (2014-11-19 05:28:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/730083002/1
6 years, 1 month ago (2014-11-19 05:46:28 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 06:42:56 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 06:43:27 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fb5e02a1616266d51c25a4ae1c72d698597a5a2
Cr-Commit-Position: refs/heads/master@{#304772}

Powered by Google App Engine
This is Rietveld 408576698