Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 729913003: Teach XHR how to handle relative urls. (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, Hixie, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Teach XHR how to handle relative urls. Hixie says window.URL may not exist yet in the sky specs, but I'm sure we'll need something like it. R=ojan@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2474837be766176bddae3c17cb7bbf3459f558cf

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M sky/framework/xmlhttprequest.sky View 3 chunks +7 lines, -1 line 3 comments Download
A + sky/tests/services/xhr-relative.sky View 1 chunk +4 lines, -7 lines 0 comments Download
A sky/tests/services/xhr-relative-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
eseidel
6 years, 1 month ago (2014-11-18 01:35:14 UTC) #1
ojan
lgtm Seems fine. I agree that we'll definitely need some way at getting at your ...
6 years, 1 month ago (2014-11-18 01:49:11 UTC) #3
esprehn
https://codereview.chromium.org/729913003/diff/1/sky/framework/xmlhttprequest.sky File sky/framework/xmlhttprequest.sky (right): https://codereview.chromium.org/729913003/diff/1/sky/framework/xmlhttprequest.sky#newcode8 sky/framework/xmlhttprequest.sky:8: var outstandingRequests = new Set(); Why do you need ...
6 years, 1 month ago (2014-11-18 02:06:24 UTC) #5
abarth-chromium
https://codereview.chromium.org/729913003/diff/1/sky/framework/xmlhttprequest.sky File sky/framework/xmlhttprequest.sky (right): https://codereview.chromium.org/729913003/diff/1/sky/framework/xmlhttprequest.sky#newcode8 sky/framework/xmlhttprequest.sky:8: var outstandingRequests = new Set(); On 2014/11/18 at 02:06:24, ...
6 years, 1 month ago (2014-11-18 02:11:59 UTC) #6
esprehn
https://codereview.chromium.org/729913003/diff/1/sky/framework/xmlhttprequest.sky File sky/framework/xmlhttprequest.sky (right): https://codereview.chromium.org/729913003/diff/1/sky/framework/xmlhttprequest.sky#newcode8 sky/framework/xmlhttprequest.sky:8: var outstandingRequests = new Set(); On 2014/11/18 02:11:59, abarth ...
6 years, 1 month ago (2014-11-18 02:15:49 UTC) #7
eseidel
Committed patchset #1 (id:1) manually as 2474837be766176bddae3c17cb7bbf3459f558cf (presubmit successful).
6 years, 1 month ago (2014-11-18 19:16:00 UTC) #8
eseidel
6 years, 1 month ago (2014-11-18 19:17:01 UTC) #9
Message was sent while issue was closed.
On 2014/11/18 02:15:49, esprehn wrote:
>
https://codereview.chromium.org/729913003/diff/1/sky/framework/xmlhttprequest...
> File sky/framework/xmlhttprequest.sky (right):
> 
>
https://codereview.chromium.org/729913003/diff/1/sky/framework/xmlhttprequest...
> sky/framework/xmlhttprequest.sky:8: var outstandingRequests = new Set();
> On 2014/11/18 02:11:59, abarth wrote:
> > On 2014/11/18 at 02:06:24, esprehn wrote:
> > > Why do you need this? I thought the Mojo JS stuff abarth@ and I worked on
> > solved this.
> > 
> > It doesn't.  :(
> > 
> > We can make the waiting callbacks strong, which would solve the problem. 
(See
> > https://codereview.chromium.org/734633004/).
> > 
> > Another option is to have the static set at the bindings layer...
> 
> Fixing this with one off Sets seems like a mistake, there's going to be so
many
> bugs.

We can change them to be strong.  I don't really care.  Landing this for now to
unblock the inspector.

Powered by Google App Engine
This is Rietveld 408576698