Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: sky/tests/services/xhr-relative.sky

Issue 729913003: Teach XHR how to handle relative urls. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tests/services/xhr-relative.sky
diff --git a/sky/tests/services/xhr.sky b/sky/tests/services/xhr-relative.sky
similarity index 52%
copy from sky/tests/services/xhr.sky
copy to sky/tests/services/xhr-relative.sky
index 7d5089b459dedd27c96b40076eb754773e229b3a..ef46a110deeaadcb0a840bec0c20d9811e766d43 100644
--- a/sky/tests/services/xhr.sky
+++ b/sky/tests/services/xhr-relative.sky
@@ -6,18 +6,15 @@
describe('XMLHttpRequest', function() {
this.enableTimeouts(false);
- it('should be able to fetch text files', function(done) {
+ it('should be able to fetch relative urls', function(done) {
var xhr = new XMLHttpRequest();
xhr.onload = function() {
- assert.equal(xhr.responseText, "This is data from the network.\n");
+ // Also testing that "this" is set correctly in the onload callback.
+ assert.equal(this.responseText, "This is data from the network.\n");
done();
};
- xhr.onerror = function(error) {
- assert.ok(false, "Got error: " + JSON.stringify(error));
- done();
- };
- xhr.open("GET", "http://127.0.0.1:8000/sky/tests/services/resources/pass.txt");
+ xhr.open("GET", "resources/pass.txt");
xhr.send();
});
});

Powered by Google App Engine
This is Rietveld 408576698