Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 729833002: Move RegisterDomain/UnregisterDomain and its handling to inspector_websocket. (Closed)

Created:
6 years, 1 month ago by chrishenry
Modified:
6 years, 1 month ago
Reviewers:
nednguyen, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move RegisterDomain/UnregisterDomain and its handling to inspector_websocket. Add unit tests. BUG=423954 Committed: https://crrev.com/79602d53643589ef1ce19cb115b1c91df4d5789f Cr-Commit-Position: refs/heads/master@{#304448} Committed: https://crrev.com/b5710e545b7719b1c36ed366145b2ce1aa8e8880 Cr-Commit-Position: refs/heads/master@{#304928}

Patch Set 1 : #

Patch Set 2 : Fix naming collision. #

Total comments: 2

Patch Set 3 : Address Ned's comment. #

Patch Set 4 : Rebase. #

Patch Set 5 : Remove try-except in domain notification handler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -114 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 1 2 3 5 chunks +3 lines, -47 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py View 1 2 3 4 7 chunks +70 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py View 1 2 3 2 chunks +158 lines, -55 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
chrishenry
6 years, 1 month ago (2014-11-15 00:42:14 UTC) #5
nednguyen
On 2014/11/15 00:42:14, chrishenry wrote: Please ping me again when the bots are green.
6 years, 1 month ago (2014-11-15 02:44:34 UTC) #6
nednguyen
lgtm https://codereview.chromium.org/729833002/diff/70001/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py File tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py (right): https://codereview.chromium.org/729833002/diff/70001/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py#newcode52 tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py:52: Can you add documentation for args? e.g: notification_handler: ...
6 years, 1 month ago (2014-11-17 17:08:16 UTC) #7
chrishenry
Fixed previous bot redness (due to method name collision). https://codereview.chromium.org/729833002/diff/70001/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py File tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py (right): https://codereview.chromium.org/729833002/diff/70001/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py#newcode52 tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py:52: ...
6 years, 1 month ago (2014-11-17 18:19:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729833002/90001
6 years, 1 month ago (2014-11-17 18:20:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:90001)
6 years, 1 month ago (2014-11-17 19:15:44 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/79602d53643589ef1ce19cb115b1c91df4d5789f Cr-Commit-Position: refs/heads/master@{#304448}
6 years, 1 month ago (2014-11-17 19:16:22 UTC) #12
nednguyen
A revert of this CL (patchset #3 id:90001) has been created in https://codereview.chromium.org/734733002/ by nednguyen@google.com. ...
6 years, 1 month ago (2014-11-17 21:14:56 UTC) #13
chrishenry
PTAL, I remove the try-except in inspector_websocket's _HandleNotification. Seems like the right thing to do. ...
6 years, 1 month ago (2014-11-19 22:25:23 UTC) #14
nednguyen
lgtm
6 years, 1 month ago (2014-11-19 22:33:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729833002/130001
6 years, 1 month ago (2014-11-19 22:34:05 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:130001)
6 years, 1 month ago (2014-11-19 23:49:16 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 23:50:08 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b5710e545b7719b1c36ed366145b2ce1aa8e8880
Cr-Commit-Position: refs/heads/master@{#304928}

Powered by Google App Engine
This is Rietveld 408576698