tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py - Issue 729833002: Move RegisterDomain/UnregisterDomain and its handling to inspector_websocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py

Issue 729833002: Move RegisterDomain/UnregisterDomain and its handling to inspector_websocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove try-except in domain notification handler. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py b/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py

index ad63ef309b139e45bba2af867e9f0e95c0169290..7e7d0ffcbd7027604ea129334becd680a700f2b4 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py

@@ -22,8 +22,9 @@ class TracingHasNotRunException(Exception):

class TracingBackend(object):

def __init__(self, devtools_port, chrome_browser_backend):

self._inspector_websocket = inspector_websocket.InspectorWebsocket(

- self._NotificationHandler,

self._ErrorHandler)

+ self._inspector_websocket.RegisterDomain(

+ 'Tracing', self._NotificationHandler)

self._inspector_websocket.Connect(

'ws://127.0.0.1:%i/devtools/browser' % devtools_port)

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py ('k') | no next file » | no next file with comments »