Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 729373004: Watch out for SkFixed overflow in SkMipMap.cpp. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Watch out for SkFixed overflow in SkMipMap.cpp. Tested with -fsanitize=signed-integer-overflow. This new assert used to trigger in MipMap unit test. Don't appear to be any GM diffs. BUG=skia: Committed: https://skia.googlesource.com/skia/+/09a22e9597e271c44dc7c2b71c72cf62a7de1e19

Patch Set 1 #

Total comments: 1

Patch Set 2 : nan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M include/core/SkTypes.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkMipMap.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
6 years, 1 month ago (2014-11-17 17:56:01 UTC) #2
reed1
lgtm w/ nit for comment or diff symbol https://codereview.chromium.org/729373004/diff/1/include/core/SkTypes.h File include/core/SkTypes.h (right): https://codereview.chromium.org/729373004/diff/1/include/core/SkTypes.h#newcode355 include/core/SkTypes.h:355: SkASSERT(value ...
6 years, 1 month ago (2014-11-21 17:10:48 UTC) #3
mtklein
Done.
6 years, 1 month ago (2014-11-21 19:26:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729373004/20001
6 years, 1 month ago (2014-11-21 19:27:30 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 19:38:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/09a22e9597e271c44dc7c2b71c72cf62a7de1e19

Powered by Google App Engine
This is Rietveld 408576698