include/core/SkTypes.h - Issue 729373004: Watch out for SkFixed overflow in SkMipMap.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTypes.h

Issue 729373004: Watch out for SkFixed overflow in SkMipMap.cpp. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nan Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTypes.h

diff --git a/include/core/SkTypes.h b/include/core/SkTypes.h

index 0e9e2303493f40fa03e386d5a189cd50be4e6e51..a38be84d8fbc38325ae217fc265a2ccc5dfb0b23 100644

--- a/include/core/SkTypes.h

+++ b/include/core/SkTypes.h

@@ -352,6 +352,7 @@ template <typename T> inline void SkTSwap(T& a, T& b) {

}

static inline int32_t SkAbs32(int32_t value) {

+ SkASSERT(value != SK_NaN32); // The most negative int32_t can't be negated.

if (value < 0) {

value = -value;

}

« no previous file with comments | « no previous file | src/core/SkMipMap.cpp » ('j') | no next file with comments »