Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 728973002: Add TaskForPID() (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@process_info
Project:
crashpad
Visibility:
Public.

Description

Add TaskForPID(). This also transitions exception_port_tool to use TaskForPID(), so that it can be safely used as a setuid executable without giving permission to operate on any process on the system. It is difficult to provide a test for this function, because it must be running setuid root in order to do anything interesting. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/de3c46c6b396e6600fcdb04146586c1962b96d00

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -12 lines) Patch
M tools/exception_port_tool.ad View 2 chunks +9 lines, -5 lines 0 comments Download
M tools/exception_port_tool.cc View 3 chunks +3 lines, -7 lines 0 comments Download
A util/mach/task_for_pid.h View 1 chunk +59 lines, -0 lines 0 comments Download
A util/mach/task_for_pid.cc View 1 1 chunk +167 lines, -0 lines 0 comments Download
M util/util.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/727973002/.
6 years, 1 month ago (2014-11-14 21:52:03 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/728973002/diff/1/util/mach/task_for_pid.cc File util/mach/task_for_pid.cc (right): https://codereview.chromium.org/728973002/diff/1/util/mach/task_for_pid.cc#newcode48 util/mach/task_for_pid.cc:48: // different_groups will only contain elements of groups ...
6 years, 1 month ago (2014-11-14 22:50:15 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-11-14 22:56:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
de3c46c6b396e6600fcdb04146586c1962b96d00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698