Add TaskForPID()

tools/exception_port_tool.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 15 matching lines @@
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/mac/mach_logging.h"
 #include "base/mac/scoped_mach_port.h"
 #include "base/strings/stringprintf.h"
 #include "tools/tool_support.h"
 #include "util/mach/exception_ports.h"
 #include "util/mach/mach_extensions.h"
 #include "util/mach/symbolic_constants_mach.h"
+#include "util/mach/task_for_pid.h"
 #include "util/stdlib/string_number_conversion.h"
 
 namespace crashpad {
 namespace {
 
 //! \brief Manages a pool of Mach send rights, deallocating all send rights upon
 //!     destruction.
 //!
 //! This class effectively implements what a vector of
 //! base::mac::ScopedMachSendRight objects would be.
@@ skipping 266 matching lines @@
 
 void Usage(const std::string& me) {
   fprintf(stderr,
 "Usage: %s [OPTION]... [COMMAND [ARG]...]\n"
 "View and change Mach exception ports, and run COMMAND if supplied.\n"
 "\n"
 "  -s, --set_handler=DESCRIPTION  set an exception port to DESCRIPTION, see below\n"
 "      --show_bootstrap=SERVICE   look up and display a service registered with\n"
 "                                 the bootstrap server\n"
 "  -p, --pid=PID                  operate on PID instead of the current task\n"
-"                                 (must be superuser or permitted by taskgated)\n"
 "  -h, --show_host                display original host exception ports\n"
 "  -t, --show_task                display original task exception ports\n"
 "      --show_thread              display original thread exception ports\n"
 "  -H, --show_new_host            display modified host exception ports\n"
 "  -T, --show_new_task            display modified task exception ports\n"
 "      --show_new_thread          display modified thread exception ports\n"
 "  -n, --numeric                  display values numerically, not symbolically\n"
 "      --help                     display this help and exit\n"
 "      --version                  output version information and exit\n"
 "\n"
@@ skipping 156 matching lines @@
     return kExitFailure;
   }
 
   base::mac::ScopedMachSendRight alternate_task_owner;
   if (options.pid) {
     if (argc) {
       ToolSupport::UsageHint(me, "cannot combine -p with COMMAND");
       return kExitFailure;
     }
 
-    // This is only expected to work as root or if taskgated approves.
-    // taskgated does not normally approve.
-    kern_return_t kr =
-        task_for_pid(mach_task_self(), options.pid, &options.alternate_task);
-    if (kr != KERN_SUCCESS) {
-      MACH_LOG(ERROR, kr) << "task_for_pid";
+    options.alternate_task = TaskForPID(options.pid);
+    if (options.alternate_task == TASK_NULL) {
       return kExitFailure;
     }
     alternate_task_owner.reset(options.alternate_task);
   }
 
   MachSendRightPool mach_send_right_pool;
 
   // Show bootstrap services requested.
   for (const char* service : options.show_bootstrap) {
     ShowBootstrapService(service, &mach_send_right_pool);
@@ skipping 69 matching lines @@
 
   return kExitSuccess;
 }
 
 }  // namespace
 }  // namespace crashpad
 
 int main(int argc, char* argv[]) {
   return crashpad::ExceptionPortToolMain(argc, argv);
 }