Enforce pure virtual behavior for onMatchFamilyStyleCharacter

Enforce pure virtual behavior for onMatchFamilyStyleCharacter

All impls that previously did not define the functions have been
updated to return NULL.

NOTRY=true

Committed: https://skia.googlesource.com/skia/+/33068c19f1b8c18f000c18935ad11f1082534b5a

[djsollen, 2014-11-14 16:44:52]

djsollen@google.com changed reviewers:
+ bungeman@google.com

[djsollen, 2014-11-14 16:46:01]

This CL is in prep for a follow on that enforces that our public includes don't
contain unused params.

[djsollen, 2014-11-14 16:55:22]

djsollen@google.com changed reviewers:
+ reed@google.com

[reed1, 2014-11-14 16:59:42]

I'm ok with this, but also ok with having a default impl. In this case esp., it
is sort of a specialty routine where returning null can be seen as ok.

[djsollen, 2014-11-14 17:01:49]

On 2014/11/14 16:59:42, reed1 wrote:
> I'm ok with this, but also ok with having a default impl. In this case esp.,
it
> is sort of a specialty routine where returning null can be seen as ok.

I only did it this way to avoid having to mark up the default impl where I had
to comment all the params out.  Also, there was a comment that this should be
done anyway so I went this route instead of commenting.

[reed1, 2014-11-14 17:02:36]

On 2014/11/14 17:01:49, djsollen wrote:
> On 2014/11/14 16:59:42, reed1 wrote:
> > I'm ok with this, but also ok with having a default impl. In this case esp.,
> it
> > is sort of a specialty routine where returning null can be seen as ok.
> 
> I only did it this way to avoid having to mark up the default impl where I had
> to comment all the params out.  Also, there was a comment that this should be
> done anyway so I went this route instead of commenting.

I defer to bunge

[bungeman-skia, 2014-11-14 18:03:40]

On 2014/11/14 17:02:36, reed1 wrote:
> On 2014/11/14 17:01:49, djsollen wrote:
> > On 2014/11/14 16:59:42, reed1 wrote:
> > > I'm ok with this, but also ok with having a default impl. In this case
esp.,
> > it
> > > is sort of a specialty routine where returning null can be seen as ok.
> > 
> > I only did it this way to avoid having to mark up the default impl where I
had
> > to comment all the params out.  Also, there was a comment that this should
be
> > done anyway so I went this route instead of commenting.
> 
> I defer to bunge

You'll need to catch 'em all.

git grep ": public SkFontMgr"

[djsollen, 2014-11-14 18:26:27]

I thought I did as some already have the function defined.

[bungeman-skia, 2014-11-14 18:35:30]

lgtm

[djsollen, 2014-11-14 18:35:46]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-11-14 18:36:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/728873002/20001

[commit-bot: I haz the power, 2014-11-14 18:52:58]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/33068c19f1b8c18f000c18935ad11f1082534b5a