src/fonts/SkFontMgr_fontconfig.cpp - Issue 728873002: Enforce pure virtual behavior for onMatchFamilyStyleCharacter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/fonts/SkFontMgr_fontconfig.cpp

Issue 728873002: Enforce pure virtual behavior for onMatchFamilyStyleCharacter (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add missing impl Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/fonts/SkFontMgr_fontconfig.cpp

diff --git a/src/fonts/SkFontMgr_fontconfig.cpp b/src/fonts/SkFontMgr_fontconfig.cpp

index 4f99a6f5c1f98d16c22b2af0be1aa05943438502..bc667e7dbee0cae227e5a0799f19f0df09c22e3b 100644

--- a/src/fonts/SkFontMgr_fontconfig.cpp

+++ b/src/fonts/SkFontMgr_fontconfig.cpp

@@ -285,6 +285,11 @@ protected:

virtual SkTypeface* onMatchFamilyStyle(const char familyName[],

const SkFontStyle&) const SK_OVERRIDE { return NULL; }

+ virtual SkTypeface* onMatchFamilyStyleCharacter(const char familyName[], const SkFontStyle&,

+ const char* bcp47[], int bcp47Count,

+ SkUnichar character) const SK_OVERRIDE {

+ return NULL;

+ }

virtual SkTypeface* onMatchFaceStyle(const SkTypeface*,

const SkFontStyle&) const SK_OVERRIDE { return NULL; }

« no previous file with comments | « include/ports/SkFontMgr.h ('k') | src/ports/SkFontHost_linux.cpp » ('j') | no next file with comments »